Beds 128/add formatting #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2024 15:46
Add recommendations for - extensions - rulers - conventional commits `scopes` See: BIDS-128
Deploying beaconchain with
|
| Latest commit: |
ccb1398
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42347b40.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-128-add-formatting.beaconchain.pages.dev |
marcel-bitfly
commented
Aug 8, 2024
MauserBitfly
reviewed
Aug 8, 2024
marcel-bitfly
force-pushed
the
BEDS-128/add-formatting
branch
from
9ce1cdc to
58a805f
Compare
MauserBitfly
reviewed
Aug 8, 2024
MauserBitfly
reviewed
Aug 8, 2024
| </script> | ||
|
|
||
| <template> | ||
| <div class="text"> | ||
| {{ props?.description || $t('premium.description') }} | ||
| {{ props?.description || $t("premium.description") }} |
There was a problem hiding this comment.
Having single quotes in the main script part and double quotes in the inline script seems a bit inconsistent?
There was a problem hiding this comment.
could be enforced...is not atm:
https://eslint.vuejs.org/rules/html-quotes.html
have a special look at avoid escape and tell me if I should
There was a problem hiding this comment.
this might got introduced due to prettier formatting I used to get rid of most of the max-len issues
marcel-bitfly
force-pushed
the
BEDS-128/add-formatting
branch
4 times, most recently
from
2fd0ce1 to
50de659
Compare
MauserBitfly
reviewed
Aug 8, 2024
MauserBitfly
reviewed
Aug 8, 2024
marcel-bitfly
force-pushed
the
BEDS-128/add-formatting
branch
2 times, most recently
from
a476983 to
ee6a8e6
Compare
See: https://eslint.style/rules See: BIDS-128
marcel-bitfly
force-pushed
the
BEDS-128/add-formatting
branch
from
ee6a8e6 to
2f63bdc
Compare
⚠️ the files where autofixed by `prettier` formatting. In order to get rid of most of the `max-len` errors. That is why there are changes included that have nothing todo with `max-len`, but also do not collide with the current `eslint stylisit set`. See: BIDS-128
marcel-bitfly
force-pushed
the
BEDS-128/add-formatting
branch
from
2f63bdc to
ccb1398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint stylisticrulesmax-len